NO-ISSUE: Add git tree check to ci-job and fix operator-sdk Makefile usage #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@donpenney: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
donpenney
requested review from
leo8a and
irinamihai
and removed request for
danielerez
|
/lgtm |
donpenney
force-pushed
the
add-git-tree-check
branch
from
1d6958b
to
a713fca
Compare
|
/lgtm |
This update includes the following changes: - Added a git tree check to the ci-job to ensure all changes are included in a PR. - Update vendor folder with missing changes from earlier PR - Update Makefile operator-sdk rules to use the downloaded executable, rather than the executable in the user's PATH Signed-off-by: Don Penney <[email protected]>
donpenney
force-pushed
the
add-git-tree-check
branch
from
a713fca
to
1615682
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: donpenney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update includes the following changes: